Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 178913003: Add missing USED_FROM_MULTIPLE_THREADS(EventSource) declaration. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add missing USED_FROM_MULTIPLE_THREADS(EventSource) declaration. EventSource is available to Web Workers; declare its ThreadingTrait accordingly. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/heap/ThreadState.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look. (Assert seen when running http/tests/eventsource/workers/eventsource-simple.html)
6 years, 10 months ago (2014-02-24 22:34:31 UTC) #1
haraken
LGTM. Thanks!
6 years, 10 months ago (2014-02-24 23:13:10 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-25 06:06:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/178913003/1
6 years, 10 months ago (2014-02-25 06:11:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/178913003/1
6 years, 10 months ago (2014-02-25 07:44:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/178913003/1
6 years, 10 months ago (2014-02-25 13:25:41 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 19:43:16 UTC) #7
Message was sent while issue was closed.
Change committed as 167818

Powered by Google App Engine
This is Rietveld 408576698