third_party/WebKit/Source/platform/graphics/PicturePattern.cpp - Issue 1789063005: Add sk_sp helpers and switch Blink SkShader clients to the new APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/PicturePattern.cpp

Issue 1789063005: Add sk_sp helpers and switch Blink SkShader clients to the new APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fromSkSp, review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp ('K') | « third_party/WebKit/Source/platform/graphics/PicturePattern.h ('k') | third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/PicturePattern.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/PicturePattern.cpp b/third_party/WebKit/Source/platform/graphics/PicturePattern.cpp

index 728a27e84b67925f3b8bc508a5d6b03d9236d02f..bbd104639f31368568bed4dd4fc464293f9a0942 100644

--- a/third_party/WebKit/Source/platform/graphics/PicturePattern.cpp

+++ b/third_party/WebKit/Source/platform/graphics/PicturePattern.cpp

@@ -10,13 +10,13 @@

namespace blink {

-PassRefPtr<PicturePattern> PicturePattern::create(PassRefPtr<const SkPicture> picture,

+PassRefPtr<PicturePattern> PicturePattern::create(PassRefPtr<SkPicture> picture,

RepeatMode repeatMode)

{

return adoptRef(new PicturePattern(picture, repeatMode));

}

-PicturePattern::PicturePattern(PassRefPtr<const SkPicture> picture, RepeatMode mode)

+PicturePattern::PicturePattern(PassRefPtr<SkPicture> picture, RepeatMode mode)

: Pattern(mode)

, m_tilePicture(picture)

{

@@ -35,7 +35,7 @@ PassRefPtr<SkShader> PicturePattern::createShader()

SkMatrix localMatrix = affineTransformToSkMatrix(m_patternSpaceTransformation);

SkRect tileBounds = m_tilePicture->cullRect();

- return adoptRef(SkShader::CreatePictureShader(m_tilePicture.get(),

+ return fromSkSp(SkShader::MakePictureShader(toSkSp(m_tilePicture),

SkShader::kRepeat_TileMode, SkShader::kRepeat_TileMode, &localMatrix, &tileBounds));

}