Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 178903004: RenderLayerScrollableArea::updateScrollCornerStyle shouldn't do work if we're using overlay scrollb… (Closed)

Created:
6 years, 9 months ago by abarth-chromium
Modified:
6 years, 9 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., ojan
Visibility:
Public.

Description

RenderLayerScrollableArea::updateScrollCornerStyle shouldn't do work if we're using overlay scrollbars This function showed up on a profile of updateStyle in Silk's toggle_drawer test case, but there no reason to update the scroll corner style if we're using overlay scrollbars. If the author has created a custom scrollbar, we'll realize that we don't have overlay scrollbars. R=esprehn@chromium.org BUG=335703 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168601

Patch Set 1 #

Patch Set 2 : Moar checks #

Patch Set 3 : Fix the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
6 years, 9 months ago (2014-03-05 23:48:58 UTC) #1
esprehn
lgtm
6 years, 9 months ago (2014-03-05 23:54:01 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 9 months ago (2014-03-06 00:35:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/178903004/20001
6 years, 9 months ago (2014-03-06 00:35:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:09:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-06 01:09:38 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-06 01:15:11 UTC) #7
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 9 months ago (2014-03-06 01:15:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/178903004/20001
6 years, 9 months ago (2014-03-06 01:15:51 UTC) #9
abarth-chromium
The test was failing due to scroll bars that appear during layout. This CL updates ...
6 years, 9 months ago (2014-03-06 01:54:38 UTC) #10
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-06 01:54:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/178903004/40001
6 years, 9 months ago (2014-03-06 01:55:12 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 08:24:39 UTC) #13
Message was sent while issue was closed.
Change committed as 168601

Powered by Google App Engine
This is Rietveld 408576698