Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: lib/src/codegen/js_field_storage.dart

Issue 1788973002: Remove code that requires whole-program compile (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: merged Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | lib/src/codegen/js_printer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_field_storage.dart
diff --git a/lib/src/codegen/js_field_storage.dart b/lib/src/codegen/js_field_storage.dart
index 8828ade81a70675a32f6db30fec11cad8d85b7a8..88de7584d06e808c49827c0122d7ae7325909c32 100644
--- a/lib/src/codegen/js_field_storage.dart
+++ b/lib/src/codegen/js_field_storage.dart
@@ -7,15 +7,14 @@ import 'package:analyzer/dart/ast/ast.dart' show Identifier;
import 'package:analyzer/dart/element/element.dart';
import 'js_codegen.dart' show ExtensionTypeSet;
-import '../info.dart' show LibraryUnit;
/// We use a storage slot for fields that override or can be overridden by
/// getter/setter pairs.
HashSet<FieldElement> findFieldsNeedingStorage(
- LibraryUnit library, ExtensionTypeSet extensionTypes) {
+ Iterable<CompilationUnitElement> units, ExtensionTypeSet extensionTypes) {
var overrides = new HashSet<FieldElement>();
- for (var unit in library.partsThenLibrary) {
- for (var cls in unit.element.types) {
+ for (var unit in units) {
+ for (var cls in unit.types) {
var superclasses = getSuperclasses(cls);
for (var field in cls.fields) {
if (!field.isSynthetic && !overrides.contains(field)) {
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | lib/src/codegen/js_printer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698