Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1788973002: Remove code that requires whole-program compile (Closed)

Created:
4 years, 9 months ago by Jennifer Messerly
Modified:
4 years, 9 months ago
Reviewers:
vsm, ochafik
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove code that requires whole-program compile This change removes functionality that is not part of the core Dart Dev Compiler, in particular those features that were not designed for incremental/modular compilation. For a while, the primary way to use DDC will be as a compiler invoked by a build system, e.g. make or bazel or some node.js based-build system. We'd love to see the user functionality provided by these return. In particular, a well designed server+watcher system would be a huge boost to productivity! I'll see about moving over HTML reporting to Analyzer CLI. It has a lovely UI. Thanks to everyone who contributed these features. The following features were removed: * DDC transformer. Transformers require whole world, in memory files. * DDC server. The server has its own mini-build system. * Various kinds of reporting. These should be moved to Analyzer CLI. Note: batch compiler and the node runner are left for now. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d230731ec991652fbee64fa217333c06150d4026

Patch Set 1 #

Total comments: 1

Patch Set 2 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -18081 lines) Patch
M .travis.yml View 1 chunk +0 lines, -3 lines 0 comments Download
M bin/dartdevc.dart View 2 chunks +2 lines, -7 lines 0 comments Download
D bin/dev_compiler.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M lib/devc.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
D lib/runtime/messages.css View 1 chunk +0 lines, -78 lines 0 comments Download
D lib/runtime/messages_widget.dart View 1 chunk +0 lines, -129 lines 0 comments Download
D lib/runtime/messages_widget.js View 1 chunk +0 lines, -13200 lines 0 comments Download
D lib/runtime/messages_widget.js.map View 1 chunk +0 lines, -8 lines 0 comments Download
D lib/src/codegen/code_generator.dart View 1 1 chunk +0 lines, -124 lines 0 comments Download
M lib/src/codegen/html_codegen.dart View 2 chunks +0 lines, -112 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 7 chunks +72 lines, -23 lines 0 comments Download
M lib/src/codegen/js_field_storage.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M lib/src/codegen/js_printer.dart View 1 5 chunks +7 lines, -13 lines 0 comments Download
M lib/src/codegen/reify_coercions.dart View 1 2 chunks +11 lines, -10 lines 0 comments Download
M lib/src/compiler.dart View 1 7 chunks +7 lines, -31 lines 0 comments Download
D lib/src/info.dart View 1 1 chunk +0 lines, -113 lines 0 comments Download
M lib/src/options.dart View 13 chunks +5 lines, -76 lines 0 comments Download
M lib/src/report.dart View 2 chunks +0 lines, -273 lines 0 comments Download
D lib/src/report/html_gen.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D lib/src/report/html_reporter.dart View 1 1 chunk +0 lines, -532 lines 0 comments Download
D lib/src/server/dependency_graph.dart View 1 1 chunk +0 lines, -543 lines 0 comments Download
D lib/src/server/server.dart View 1 chunk +0 lines, -339 lines 0 comments Download
D lib/src/summary.dart View 1 chunk +0 lines, -247 lines 0 comments Download
D lib/src/transformer/asset_source.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D lib/src/transformer/asset_universe.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D lib/src/transformer/error_listener.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D lib/src/transformer/transformer.dart View 1 chunk +0 lines, -134 lines 0 comments Download
D lib/src/transformer/uri_resolver.dart View 1 chunk +0 lines, -88 lines 0 comments Download
M lib/src/utils.dart View 1 2 chunks +0 lines, -13 lines 0 comments Download
D lib/transformer.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 3 chunks +1 line, -5 lines 0 comments Download
M test/all_tests.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M test/codegen_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
D test/dependency_graph_test.dart View 1 chunk +0 lines, -1251 lines 0 comments Download
D test/report_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
M test/testing.dart View 2 chunks +0 lines, -21 lines 0 comments Download
D test/transformer/hello_app/pubspec.yaml View 1 chunk +0 lines, -15 lines 0 comments Download
D test/transformer/hello_app/web/index.html View 1 chunk +0 lines, -7 lines 0 comments Download
D test/transformer/hello_app/web/main.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D test/transformer/hello_dep/lib/simple.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D test/transformer/hello_dep/lib/utils.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D test/transformer/hello_dep/pubspec.yaml View 1 chunk +0 lines, -2 lines 0 comments Download
D test/transformer_e2e_test.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D test/transformer_test.dart View 1 chunk +0 lines, -100 lines 0 comments Download
M tool/presubmit.sh View 1 chunk +0 lines, -1 line 0 comments Download
D tool/transformer_test.sh View 1 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Jennifer Messerly
@Vijay, this is the follow up to your message: https://groups.google.com/a/dartlang.org/d/msg/dev-compiler/M82d7MphW8M/7Z2OuZZgAgAJ
4 years, 9 months ago (2016-03-12 01:36:09 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/1788973002/diff/1/lib/src/codegen/reify_coercions.dart File lib/src/codegen/reify_coercions.dart (right): https://codereview.chromium.org/1788973002/diff/1/lib/src/codegen/reify_coercions.dart#newcode64 lib/src/codegen/reify_coercions.dart:64: // TODO(jmesserly): what is going on here? We are ...
4 years, 9 months ago (2016-03-12 01:37:36 UTC) #5
vsm
lgtm Let's publish a new DDC before landing this. This may break some Angular work, ...
4 years, 9 months ago (2016-03-14 14:39:16 UTC) #6
ochafik
Hey John, re/ the transformer, my plan was to make it incremental as soon as ...
4 years, 9 months ago (2016-03-14 15:44:51 UTC) #8
Jennifer Messerly
On 2016/03/14 15:44:51, ochafik wrote: > Hey John, re/ the transformer, my plan was to ...
4 years, 9 months ago (2016-03-14 22:40:45 UTC) #9
vsm
On 2016/03/14 22:40:45, John Messerly wrote: > On 2016/03/14 15:44:51, ochafik wrote: > > Hey ...
4 years, 9 months ago (2016-03-15 17:38:48 UTC) #10
Jennifer Messerly
4 years, 9 months ago (2016-03-15 18:30:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d230731ec991652fbee64fa217333c06150d4026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698