Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1788953002: Do a check for nacl being enabled in devenv glibc. (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Do a check for nacl being enabled in devenv glibc. Check that nacl is enabled on devenv start to avoid user confusion (shows message if not). Change the verbiage around allowing local nexe runs to be less certain, since we may not do this. BUG=None TEST=devenv R=binji@chromium.org,petewil@chromium.org Committed: https://chromium.googlesource.com/webports/+/f1f52859fac35f533abb1133c9c04b384b004479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ports/devenv/install-base-packages.sh View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bradn
4 years, 9 months ago (2016-03-11 23:59:38 UTC) #2
Pete Williamson
LGTM Thanks for doing this! I think it will be a big help for users ...
4 years, 9 months ago (2016-03-12 00:07:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788953002/1
4 years, 9 months ago (2016-03-12 00:15:51 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 01:53:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/webports/+/f1f52859fac35f533abb1133c9c04b38...

Powered by Google App Engine
This is Rietveld 408576698