Simplify GM-as-bench code.

bench/benchmain.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "BenchTimer.h"
 #include "ResultsWriter.h"
 #include "SkBenchLogger.h"
@@ skipping 17 matching lines @@
 #include "GrContextFactory.h"
 #include "GrRenderTarget.h"
 #include "SkGpuDevice.h"
 #include "gl/GrGLDefines.h"
 #else
 class GrContext;
 #endif // SK_SUPPORT_GPU
 
 #include <limits>
 
-// Note that ~SkTDArray is not virtual. This inherits privately to bar using this as a SkTDArray*.
-class RefCntArray : private SkTDArray<SkRefCnt*> {
-public:
-    SkRefCnt** append() { return this->INHERITED::append(); }
-    ~RefCntArray() { this->unrefAll(); }
-private:
-    typedef SkTDArray<SkRefCnt*> INHERITED;
-};
-
-class GMBenchFactory : public SkBenchmarkFactory {
-public:
-    GMBenchFactory(const skiagm::GMRegistry* gmreg)
-    : fGMFactory(gmreg->factory()) {
-        fSelfRegistry = SkNEW_ARGS(BenchRegistry, (this));
-    }
-
-    virtual ~GMBenchFactory() { SkDELETE(fSelfRegistry); }
-
-    virtual SkBenchmark* operator()() const SK_OVERRIDE {
-        skiagm::GM* gm = fGMFactory(NULL);
-        gm->setMode(skiagm::GM::kBench_Mode);
-        return SkNEW_ARGS(SkGMBench, (gm));
-    }
-
-private:
-    skiagm::GMRegistry::Factory fGMFactory;
-    BenchRegistry*              fSelfRegistry;
-};
-
-static void register_gm_benches() {
-    static bool gOnce;
-    static RefCntArray gGMBenchFactories;
-
-    if (!gOnce) {
-        const skiagm::GMRegistry* gmreg = skiagm::GMRegistry::Head();
-        while (gmreg) {
-            skiagm::GM* gm = gmreg->factory()(NULL);
-            if (NULL != gm  && skiagm::GM::kAsBench_Flag & gm->getFlags()) {
-                *gGMBenchFactories.append() = SkNEW_ARGS(GMBenchFactory, (gmreg));
-            }
-            SkDELETE(gm);
-            gmreg = gmreg->next();
-        }
-        gOnce = true;
-    }
-}
-
 enum BenchMode {
     kNormal_BenchMode,
     kDeferred_BenchMode,
     kDeferredSilent_BenchMode,
     kRecord_BenchMode,
     kPictureRecord_BenchMode
 };
 const char* BenchMode_Name[] = {
     "normal", "deferred", "deferredSilent", "record", "picturerecord"
 };
 
 static const char kDefaultsConfigStr[] = "defaults";
 
 ///////////////////////////////////////////////////////////////////////////////
 
 class Iter {
 public:
-    Iter() : fBench(BenchRegistry::Head()) {}
+    Iter() : fBenches(BenchRegistry::Head()), fGMs(skiagm::GMRegistry::Head()) {}
 
     SkBenchmark* next() {
-        if (fBench) {
-            BenchRegistry::Factory f = fBench->factory();
-            fBench = fBench->next();
+        if (fBenches) {
+            BenchRegistry::Factory f = fBenches->factory();
+            fBenches = fBenches->next();
             return (*f)();
         }
+
+        while (fGMs) {
+            SkAutoTDelete<skiagm::GM> gm(fGMs->factory()(NULL));
+            fGMs = fGMs->next();
+            if (gm->getFlags() & skiagm::GM::kAsBench_Flag) {
+                return SkNEW_ARGS(SkGMBench, (gm.detach()));
+            }
+        }
+
         return NULL;
     }
 
 private:
-    const BenchRegistry* fBench;
+    const BenchRegistry* fBenches;
+    const skiagm::GMRegistry* fGMs;
 };
 
 class AutoPrePostDraw {
 public:
     AutoPrePostDraw(SkBenchmark* bench) : fBench(bench) {
         fBench->preDraw();
     }
     ~AutoPrePostDraw() {
         fBench->postDraw();
     }
@@ skipping 185 matching lines @@
     if (currRaw < FLAGS_minMs) {
         return false;
     }
     const double low = 1 - FLAGS_error, high = 1 + FLAGS_error;
     const double ratio = currPerLoop / prevPerLoop;
     return low < ratio && ratio < high;
 }
 
 int tool_main(int argc, char** argv);
 int tool_main(int argc, char** argv) {
-    register_gm_benches();
     SkCommandLineFlags::Parse(argc, argv);
 #if SK_ENABLE_INST_COUNT
     if (FLAGS_leaks) {
         gPrintInstCount = true;
     }
 #endif
     SkAutoGraphics ag;
 
     // First, parse some flags.
     SkBenchLogger logger;
@@ skipping 387 matching lines @@
     gContextFactory.destroyContexts();
 #endif
     return 0;
 }
 
 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)
 int main(int argc, char * const argv[]) {
     return tool_main(argc, (char**) argv);
 }
 #endif