Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1788873004: Subzero: Fix the Makefile for the LLVM build. (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix the Makefile for the LLVM build. https://codereview.chromium.org/1784243006/ added the ALLOW_TIMERS define, and I forgot to add it to Makefile and CMakeLists.txt. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1670eceaefaaacaf424fe04d4776c5d03f0324be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M CMakeLists.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 9 months ago (2016-03-12 00:45:44 UTC) #3
John
lgtm
4 years, 9 months ago (2016-03-12 17:43:44 UTC) #4
Jim Stichnoth
4 years, 9 months ago (2016-03-12 18:04:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1670eceaefaaacaf424fe04d4776c5d03f0324be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698