Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1788753002: [heap] Remove left-overs of RESCAN_ON_EVACUATION flag. (Closed)

Created:
4 years, 9 months ago by Michael Lippautz
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove left-overs of RESCAN_ON_EVACUATION flag. The code actually setting this flag has already been removed. This CL merely removes dead code. BUG= Committed: https://crrev.com/e94850ea6279a41f483facb184f350283a37b022 Cr-Commit-Position: refs/heads/master@{#34729}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -55 lines) Patch
M src/heap/mark-compact.cc View 1 4 chunks +13 lines, -52 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Lippautz
ptal - as discussed, let's remove the left-overs.
4 years, 9 months ago (2016-03-11 15:18:05 UTC) #2
ulan
lgtm
4 years, 9 months ago (2016-03-11 15:20:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788753002/20001
4 years, 9 months ago (2016-03-11 15:20:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 15:43:40 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 15:45:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e94850ea6279a41f483facb184f350283a37b022
Cr-Commit-Position: refs/heads/master@{#34729}

Powered by Google App Engine
This is Rietveld 408576698