Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1788713003: Fix EGL configs with ozone and surfaceless surfaces. (Closed)

Created:
4 years, 9 months ago by dnicoara
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix EGL configs with ozone and surfaceless surfaces. This CL fixes a bug where GLSurfaceOzoneSurfaceless was not calling SurfaceOzoneEGL::GetEGLSurfaceConfig(). Instead, the default implementation in GLSurfaceEGL::GetConfig() would be used to pick an EGL config. This resulted in "No suitable EGL configs found." being logged everytime a GLSurfaceOzoneSurfaceless was created. Instead it now calls SurfaceOzoneEGL::GetEGLSurfaceConfig(). For offscreen surfaces SurfacelessEGL is used. This produced the same error message on creation. SurfaceOzoneEGL::GetEGLSurfaceConfig() can't be used with offscren surfaces as there is no window associated with the offscreen surface. Instead, the EGL_SURFACE_TYPE attribute is set to EGL_DONT_CARE in GLSurfaceEGL::GetConfig() for surfaceless surfaces. The bug doesn't seem to cause problems beyond the logged error messages as drawing still works under Ozone. BUG=591064 Review URL: https://codereview.chromium.org/1738973004 Cr-Commit-Position: refs/heads/master@{#380171} (cherry picked from commit 445089ac3c1b949fb4248f3aef3ce5e7acd66d92) Committed: https://chromium.googlesource.com/chromium/src/+/b4856fdf503827b541ed0517100d7b5653782c33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M ui/gl/gl_surface.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 5 chunks +12 lines, -4 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 4 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dnicoara
4 years, 9 months ago (2016-03-11 15:36:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4856fdf503827b541ed0517100d7b5653782c33 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698