Remove uses of SkImageDecoder from skdiff

Remove uses of SkImageDecoder from skdiff

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1788643003

Committed: https://skia.googlesource.com/skia/+/667433ff5bc65680af31ca718d4cc29cce7b7040

[msarett, 2016-03-11 19:45:04]

Description was changed from

==========
Remove uses of SkImageDecoder from skdiff

BUG=skia:
==========

to

==========
Remove uses of SkImageDecoder from skdiff

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-03-11 19:45:51]

msarett@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2016-03-11 19:56:13]

lgtm

https://codereview.chromium.org/1788643003/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

https://codereview.chromium.org/1788643003/diff/1/tools/skdiff_main.cpp#newco...
tools/skdiff_main.cpp:12: #include "SkForceLinking.h"
I assume this is no longer necessary

[msarett, 2016-03-11 19:58:09]

https://codereview.chromium.org/1788643003/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

https://codereview.chromium.org/1788643003/diff/1/tools/skdiff_main.cpp#newco...
tools/skdiff_main.cpp:12: #include "SkForceLinking.h"
On 2016/03/11 19:56:13, scroggo wrote:
> I assume this is no longer necessary

I recently realized that force linking is also used by SkImageEncoder.

I'm not 100% sure, but this could potentially be required for uses of
SkImageEncoder in this file.

[scroggo, 2016-03-11 20:00:34]

https://codereview.chromium.org/1788643003/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

https://codereview.chromium.org/1788643003/diff/1/tools/skdiff_main.cpp#newco...
tools/skdiff_main.cpp:12: #include "SkForceLinking.h"
On 2016/03/11 19:58:08, msarett wrote:
> On 2016/03/11 19:56:13, scroggo wrote:
> > I assume this is no longer necessary
> 
> I recently realized that force linking is also used by SkImageEncoder.
> 
> I'm not 100% sure, but this could potentially be required for uses of
> SkImageEncoder in this file.

Really? I added force linking because we auto-register our image decoders. For
encoding, we call them directly, so the linker shouldn't be stripping them.

[msarett, 2016-03-11 20:05:47]

https://codereview.chromium.org/1788643003/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

https://codereview.chromium.org/1788643003/diff/1/tools/skdiff_main.cpp#newco...
tools/skdiff_main.cpp:12: #include "SkForceLinking.h"
On 2016/03/11 20:00:34, scroggo wrote:
> On 2016/03/11 19:58:08, msarett wrote:
> > On 2016/03/11 19:56:13, scroggo wrote:
> > > I assume this is no longer necessary
> > 
> > I recently realized that force linking is also used by SkImageEncoder.
> > 
> > I'm not 100% sure, but this could potentially be required for uses of
> > SkImageEncoder in this file.
> 
> Really? I added force linking because we auto-register our image decoders. For
> encoding, we call them directly, so the linker shouldn't be stripping them.

Maybe I'm wrong...  I'm certainly not an expert in force linking.

I'm basing this on:
https://codereview.chromium.org/1777753002/

Before Patch Set 2, the encode step would fail without even trying to create a
PNG encoder.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/s...

[msarett, 2016-03-17 13:22:09]

Looks to me like the encoders also require ForceLinking.

They are registered with a factory in the same way as SkImageDecoders.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/s...

[msarett, 2016-03-17 13:22:14]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-03-17 13:22:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1788643003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1788643003/1

[commit-bot: I haz the power, 2016-03-17 13:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 13:44:07]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-03-17 13:56:57]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-03-17 13:57:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1788643003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1788643003/1

[commit-bot: I haz the power, 2016-03-17 14:17:56]

Description was changed from

==========
Remove uses of SkImageDecoder from skdiff

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove uses of SkImageDecoder from skdiff

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/667433ff5bc65680af31ca718d4cc29cce7b7040
==========

[commit-bot: I haz the power, 2016-03-17 14:17:58]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/667433ff5bc65680af31ca718d4cc29cce7b7040