Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 178863002: Implement settings in a widnow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index 040fb413454cb059e16af3f93730e32da2e70984..985ed69070f618fd8fda25dd8044e99ecf057f8e 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -55,6 +55,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"
#include "chrome/browser/ui/tab_contents/core_tab_helper.h"
#include "chrome/common/chrome_constants.h"
@@ -1900,9 +1901,8 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
case IDC_CONTENT_CONTEXT_LANGUAGE_SETTINGS: {
WindowOpenDisposition disposition =
ForceNewTabDispositionFromEventFlags(event_flags);
- std::string url = std::string(chrome::kChromeUISettingsURL) +
- chrome::kLanguageOptionsSubPage;
- OpenURL(GURL(url), GURL(), 0, disposition, content::PAGE_TRANSITION_LINK);
+ GURL url = chrome::GetSettingsUrl(chrome::kLanguageOptionsSubPage);
+ OpenURL(url, GURL(), 0, disposition, content::PAGE_TRANSITION_LINK);
break;
}
@@ -1911,9 +1911,8 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
UserMetricsAction("RegisterProtocolHandler.ContextMenu_Settings"));
WindowOpenDisposition disposition =
ForceNewTabDispositionFromEventFlags(event_flags);
- std::string url = std::string(chrome::kChromeUISettingsURL) +
- chrome::kHandlerSettingsSubPage;
- OpenURL(GURL(url), GURL(), 0, disposition, content::PAGE_TRANSITION_LINK);
+ GURL url = chrome::GetSettingsUrl(chrome::kHandlerSettingsSubPage);
+ OpenURL(url, GURL(), 0, disposition, content::PAGE_TRANSITION_LINK);
break;
}

Powered by Google App Engine
This is Rietveld 408576698