Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 17885003: add command line flags (Closed)

Created:
7 years, 6 months ago by Zach Reizner
Modified:
7 years, 5 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : string differ flags #

Patch Set 3 : rework command line #

Total comments: 5

Patch Set 4 : add TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -20 lines) Patch
A experimental/skpdiff/README View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M experimental/skpdiff/SkCLImageDiffer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/skpdiff/main.cpp View 1 2 3 3 chunks +142 lines, -19 lines 0 comments Download
M experimental/skpdiff/skpdiff.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Zach Reizner
7 years, 6 months ago (2013-06-26 13:36:59 UTC) #1
djsollen
https://codereview.chromium.org/17885003/diff/1/experimental/skpdiff/main.cpp File experimental/skpdiff/main.cpp (right): https://codereview.chromium.org/17885003/diff/1/experimental/skpdiff/main.cpp#newcode19 experimental/skpdiff/main.cpp:19: remove https://codereview.chromium.org/17885003/diff/1/experimental/skpdiff/main.cpp#newcode29 experimental/skpdiff/main.cpp:29: DEFINE_int32(differ, 0, "The index of the ...
7 years, 6 months ago (2013-06-26 14:34:02 UTC) #2
Zach Reizner
7 years, 6 months ago (2013-06-26 20:52:50 UTC) #3
djsollen
https://codereview.chromium.org/17885003/diff/11001/experimental/skpdiff/README File experimental/skpdiff/README (right): https://codereview.chromium.org/17885003/diff/11001/experimental/skpdiff/README#newcode10 experimental/skpdiff/README:10: out/Debug/skpdiff --differ 1 -f \ update this https://codereview.chromium.org/17885003/diff/11001/experimental/skpdiff/main.cpp File ...
7 years, 5 months ago (2013-06-27 12:43:50 UTC) #4
Zach Reizner
7 years, 5 months ago (2013-06-27 13:31:36 UTC) #5
djsollen
lgtm
7 years, 5 months ago (2013-06-27 13:35:36 UTC) #6
Zach Reizner
7 years, 5 months ago (2013-06-27 17:51:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r9794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698