Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2002)

Issue 1788443005: Make TokenValidatorFactory ref-counted. (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TokenValidatorFactory ref-counted. This makes TokeValidatorFactory consistent with PairingRegistry and now it can be shared between multiple authenticator objects. Committed: https://crrev.com/a15e4f0ac7ec67afd93957fa56f1ef027ec3775a Cr-Commit-Position: refs/heads/master@{#380871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -35 lines) Patch
M remoting/host/remoting_me2me_host.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M remoting/host/token_validator_factory_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/token_validator_factory_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M remoting/protocol/negotiating_host_authenticator.h View 3 chunks +4 lines, -2 lines 0 comments Download
M remoting/protocol/negotiating_host_authenticator.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M remoting/protocol/token_validator.h View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Sergey Ulanov
4 years, 6 months ago (2016-03-11 19:33:17 UTC) #2
Jamie
lgtm
4 years, 6 months ago (2016-03-11 22:49:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788443005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788443005/1
4 years, 6 months ago (2016-03-11 23:34:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/171890) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-03-11 23:37:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788443005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788443005/1
4 years, 6 months ago (2016-03-12 06:31:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/3919) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-03-12 06:33:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1788443005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1788443005/1
4 years, 6 months ago (2016-03-12 08:17:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-03-12 09:10:07 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-03-12 09:11:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a15e4f0ac7ec67afd93957fa56f1ef027ec3775a
Cr-Commit-Position: refs/heads/master@{#380871}

Powered by Google App Engine
This is Rietveld 408576698