Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 178833002: Fix for a smi stores optimization on x64 with a regression test. (Closed)

Created:
6 years, 10 months ago by Igor Sheludko
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix for a smi stores optimization on x64 with a regression test. BUG=345715 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M src/hydrogen.cc View 1 chunk +5 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-345715.js View 1 chunk +17 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 10 months ago (2014-02-24 22:14:34 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-25 09:18:26 UTC) #2
Igor Sheludko
6 years, 10 months ago (2014-02-25 09:55:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19535 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698