SkPDF: remove all globally references SkPDFObjects

SkPDF: remove all globally references SkPDFObjects

Move these singletons into SkPDFCanon (there is still a single object
per document; output PDF size will not change).

Motivation: After this change, all indirectly-referenced SkPDFObjects
are serialized exactly once.  The next CL will add a memory saving
feature: a method to purge an object's resources immediately after
serialization.  After that, further changes wil allow some objects to be
serialized *before* SkDocument::close(), leading to potentially very
large memory savings.

BUG=skia:5087
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1788263002

Committed: https://skia.googlesource.com/skia/+/1437c1eea8f40f7a43bfe6e80a8d3f6cd61a3643

[hal.canary, 2016-03-12 17:30:09]

Description was changed from

==========
SkPDF: remove all globally references SkPDFObjects

Move these singletons into SkPDFCanon (there is still a single object
per document; output PDF size will not change).

Motivation: After this change, all indirectly-referenced SkPDFObjects
are serialized exactly once.  The next CL will add a memory saving
feature: a method to purge an object's resources immediately after
serialization.  After that, further changes wil allow some objects to be
serialized *before* SkDocument::close(), leading to potentially very
large memory savings.

BUG=skia:5087
==========

to

==========
SkPDF: remove all globally references SkPDFObjects

Move these singletons into SkPDFCanon (there is still a single object
per document; output PDF size will not change).

Motivation: After this change, all indirectly-referenced SkPDFObjects
are serialized exactly once.  The next CL will add a memory saving
feature: a method to purge an object's resources immediately after
serialization.  After that, further changes wil allow some objects to be
serialized *before* SkDocument::close(), leading to potentially very
large memory savings.

BUG=skia:5087
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-03-12 17:31:15]

halcanary@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com

[hal.canary, 2016-03-12 17:31:15]

ptal

[hal.canary, 2016-03-12 20:35:05]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-12 20:35:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1788263002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1788263002/1

[commit-bot: I haz the power, 2016-03-12 20:43:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 20:43:46]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-03-13 13:49:52]

Now that the Canon owns these, is it still important that these are also
ref-counted?  Is that for compatibility with APIs that also work with
non-singletons?

https://codereview.chromium.org/1788263002/diff/1/src/pdf/SkPDFGraphicState.cpp
File src/pdf/SkPDFGraphicState.cpp (right):

https://codereview.chromium.org/1788263002/diff/1/src/pdf/SkPDFGraphicState.c...
src/pdf/SkPDFGraphicState.cpp:162: sMaskDict->insertObjRef("TR",
canon->makeInvertFunction());
Might want to explain here why we call canon->makeInvertFunction() and not
MakeInvertFunction().

[hal.canary, 2016-03-13 19:07:21]

https://codereview.chromium.org/1788263002/diff/1/src/pdf/SkPDFGraphicState.cpp
File src/pdf/SkPDFGraphicState.cpp (right):

https://codereview.chromium.org/1788263002/diff/1/src/pdf/SkPDFGraphicState.c...
src/pdf/SkPDFGraphicState.cpp:162: sMaskDict->insertObjRef("TR",
canon->makeInvertFunction());
On 2016/03/13 13:49:52, mtklein wrote:
> Might want to explain here why we call canon->makeInvertFunction() and not
> MakeInvertFunction().

Done.

[hal.canary, 2016-03-13 19:08:54]

On 2016/03/13 13:49:52, mtklein wrote:
> Now that the Canon owns these, is it still important that these are also
> ref-counted?  Is that for compatibility with APIs that also work with
> non-singletons?

Exactly.  Either all SkPDFObjects are ref-counted or none.

[mtklein, 2016-03-14 01:12:44]

lgtm

[hal.canary, 2016-03-14 01:21:58]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-03-14 01:22:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1788263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1788263002/20001

[commit-bot: I haz the power, 2016-03-14 01:30:27]

Description was changed from

==========
SkPDF: remove all globally references SkPDFObjects

Move these singletons into SkPDFCanon (there is still a single object
per document; output PDF size will not change).

Motivation: After this change, all indirectly-referenced SkPDFObjects
are serialized exactly once.  The next CL will add a memory saving
feature: a method to purge an object's resources immediately after
serialization.  After that, further changes wil allow some objects to be
serialized *before* SkDocument::close(), leading to potentially very
large memory savings.

BUG=skia:5087
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkPDF: remove all globally references SkPDFObjects

Move these singletons into SkPDFCanon (there is still a single object
per document; output PDF size will not change).

Motivation: After this change, all indirectly-referenced SkPDFObjects
are serialized exactly once.  The next CL will add a memory saving
feature: a method to purge an object's resources immediately after
serialization.  After that, further changes wil allow some objects to be
serialized *before* SkDocument::close(), leading to potentially very
large memory savings.

BUG=skia:5087
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1437c1eea8f40f7a43bfe6e80a8d3f6cd61a3643
==========

[commit-bot: I haz the power, 2016-03-14 01:30:28]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1437c1eea8f40f7a43bfe6e80a8d3f6cd61a3643