Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1788223002: Deprecate the generated AST library and clean up imports (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deprecate the generated AST library and clean up imports R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7d72c6e1f57da3d31697574e17125acce328bb35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -134 lines) Patch
M pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/field_formal_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 2 chunks +27 lines, -27 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/name_suggestion.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/namespace.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/organize_directives.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/selection_analyzer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/sort_members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/source_range.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/split_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/ast_writer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/validator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 3 chunks +24 lines, -24 lines 0 comments Download
M pkg/analysis_server/test/plugin/protocol_dart_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/optype_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/local_index_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/abstract_single_unit.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-12 16:01:34 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-12 16:49:37 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-12 16:50:54 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7d72c6e1f57da3d31697574e17125acce328bb35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698