Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 17881004: Remove superfluous HInnerAllocatedObject in BuildEmitDeepCopy (Closed)

Created:
7 years, 6 months ago by danno
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove superfluous HInnerAllocatedObject in BuildEmitDeepCopy R=hpayer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15367

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/hydrogen.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
7 years, 6 months ago (2013-06-26 16:25:05 UTC) #1
Toon Verwaest
Dbc https://codereview.chromium.org/17881004/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/17881004/diff/1/src/hydrogen.cc#newcode10033 src/hydrogen.cc:10033: } Isn't there a utility function to test ...
7 years, 6 months ago (2013-06-27 04:32:22 UTC) #2
danno
Please take another look https://codereview.chromium.org/17881004/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/17881004/diff/1/src/hydrogen.cc#newcode10033 src/hydrogen.cc:10033: } On 2013/06/27 04:32:22, Toon ...
7 years, 5 months ago (2013-06-27 13:55:51 UTC) #3
Hannes Payer (out of office)
lgtm
7 years, 5 months ago (2013-06-27 16:04:15 UTC) #4
danno
7 years, 5 months ago (2013-06-27 16:08:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698