Issue 17881002: add globbing util function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17881002: add globbing util function (Closed)

Created:
7 years, 6 months ago by Zach Reizner

Modified:
7 years, 6 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add globbing util function R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9774

Patch Set 2 : add TODO #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	experimental/skpdiff/skpdiff_util.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	experimental/skpdiff/skpdiff_util.cpp	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm if you address the comment https://codereview.chromium.org/17881002/diff/1/experimental/skpdiff/skpdiff_util.cpp File experimental/skpdiff/skpdiff_util.cpp (right): https://codereview.chromium.org/17881002/diff/1/experimental/skpdiff/skpdiff_util.cpp#newcode100 experimental/skpdiff/skpdiff_util.cpp:100: // Heres how ...

7 years, 6 months ago (2013-06-26 13:41:18 UTC) #2

Zach Reizner

7 years, 6 months ago (2013-06-26 18:55:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r9774 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17881002: add globbing util function (Closed)

Description

Patch Set 1 #

Patch Set 2 : add TODO #

Messages