Source/wtf/text/StringImpl.cpp - Issue 178803006: Turn MQ classes into thread safe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/text/StringImpl.cpp

Issue 178803006: Turn MQ classes into thread safe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Moved string comparison optimization to StringImpl Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/wtf/text/StringImpl.cpp

diff --git a/Source/wtf/text/StringImpl.cpp b/Source/wtf/text/StringImpl.cpp

index 7628ebf28abdd53e3152e688c633fee57409a652..5ce696e6354139aa56c3b1c093936a01c6d4f39c 100644

--- a/Source/wtf/text/StringImpl.cpp

+++ b/Source/wtf/text/StringImpl.cpp

@@ -1934,6 +1934,8 @@ bool equal(const StringImpl* a, const StringImpl* b)

return true;

if (!a || !b)

return false;

+ if (a->isAtomic() && b->isAtomic())

+ return false;

abarth-chromium 2014/03/06 18:52:05 Can we land this change separately? This code is c

return stringImplContentEqual(a, b);

}

« no previous file with comments | « Source/core/html/parser/HTMLParserIdioms.cpp ('k') | no next file » | no next file with comments »