Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: Source/core/css/MediaQueryExp.h

Issue 178803006: Turn MQ classes into thread safe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed StringImpl comparison atomic check Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQueryEvaluator.cpp ('k') | Source/core/css/MediaQueryExp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaQueryExp.h
diff --git a/Source/core/css/MediaQueryExp.h b/Source/core/css/MediaQueryExp.h
index 4717180475c376437e01ab67321eb596dab3e08a..11ea6fd14aaacbe5e074fcaf1213ae6053bf733c 100644
--- a/Source/core/css/MediaQueryExp.h
+++ b/Source/core/css/MediaQueryExp.h
@@ -33,7 +33,6 @@
#include "core/css/CSSValue.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/RefPtr.h"
-#include "wtf/text/AtomicString.h"
namespace WebCore {
class CSSParserValueList;
@@ -41,10 +40,10 @@ class CSSParserValueList;
class MediaQueryExp : public NoBaseWillBeGarbageCollectedFinalized<MediaQueryExp> {
WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
public:
- static PassOwnPtrWillBeRawPtr<MediaQueryExp> create(const AtomicString& mediaFeature, CSSParserValueList*);
+ static PassOwnPtrWillBeRawPtr<MediaQueryExp> create(const String& mediaFeature, CSSParserValueList*);
~MediaQueryExp();
- AtomicString mediaFeature() const { return m_mediaFeature; }
+ const String& mediaFeature() const { return m_mediaFeature; }
CSSValue* value() const { return m_value.get(); }
@@ -66,9 +65,9 @@ public:
MediaQueryExp(const MediaQueryExp& other);
private:
- MediaQueryExp(const AtomicString& mediaFeature, PassRefPtrWillBeRawPtr<CSSValue>);
+ MediaQueryExp(const String&, PassRefPtrWillBeRawPtr<CSSValue>);
- AtomicString m_mediaFeature;
+ String m_mediaFeature;
RefPtrWillBeMember<CSSValue> m_value;
};
« no previous file with comments | « Source/core/css/MediaQueryEvaluator.cpp ('k') | Source/core/css/MediaQueryExp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698