Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: Source/core/css/MediaQueryEvaluator.h

Issue 178803006: Turn MQ classes into thread safe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed StringImpl comparison atomic check Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQuery.cpp ('k') | Source/core/css/MediaQueryEvaluator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaQueryEvaluator.h
diff --git a/Source/core/css/MediaQueryEvaluator.h b/Source/core/css/MediaQueryEvaluator.h
index 1a03b799960ff3e27e8c8279767bd36a15d2dea7..2ad036d19c11278f32b499bc3f21384a5483998a 100644
--- a/Source/core/css/MediaQueryEvaluator.h
+++ b/Source/core/css/MediaQueryEvaluator.h
@@ -65,15 +65,15 @@ public:
* Evaluator returns true for acceptedMediaType and returns value of \mediafeatureResult
* for any media features
*/
- MediaQueryEvaluator(const AtomicString& acceptedMediaType, bool mediaFeatureResult = false);
+ MediaQueryEvaluator(const String& acceptedMediaType, bool mediaFeatureResult = false);
MediaQueryEvaluator(const char* acceptedMediaType, bool mediaFeatureResult = false);
/** Creates evaluator which evaluates full media queries */
- MediaQueryEvaluator(const AtomicString& acceptedMediaType, LocalFrame*, RenderStyle*);
+ MediaQueryEvaluator(const String& acceptedMediaType, LocalFrame*, RenderStyle*);
~MediaQueryEvaluator();
- bool mediaTypeMatch(const AtomicString& mediaTypeToMatch) const;
+ bool mediaTypeMatch(const String& mediaTypeToMatch) const;
bool mediaTypeMatchSpecific(const char* mediaTypeToMatch) const;
/** Evaluates a list of media queries */
@@ -83,7 +83,7 @@ public:
bool eval(const MediaQueryExp*) const;
private:
- AtomicString m_mediaType;
+ String m_mediaType;
LocalFrame* m_frame; // Not owned.
RefPtr<RenderStyle> m_style;
bool m_expResult;
« no previous file with comments | « Source/core/css/MediaQuery.cpp ('k') | Source/core/css/MediaQueryEvaluator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698