Turn MQ classes into thread safe

Source/core/css/MediaQueryExp.h

 /*
  * CSS Media Query
  *
  * Copyright (C) 2006 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
@@ skipping 15 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef MediaQueryExp_h
 #define MediaQueryExp_h
 
 #include "MediaFeatureNames.h"
 #include "core/css/CSSValue.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/RefPtr.h"
-#include "wtf/text/AtomicString.h"
 
 namespace WebCore {
 class CSSParserValueList;
 
 class MediaQueryExp : public NoBaseWillBeGarbageCollectedFinalized<MediaQueryExp> {
     WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
 public:
-    static PassOwnPtrWillBeRawPtr<MediaQueryExp> create(const AtomicString& mediaFeature, CSSParserValueList*);
+    static PassOwnPtrWillBeRawPtr<MediaQueryExp> create(const String& mediaFeature, CSSParserValueList*);
     ~MediaQueryExp();
 
-    AtomicString mediaFeature() const { return m_mediaFeature; }
+    String mediaFeature() const { return m_mediaFeature; }

[abarth-chromium, 2014/03/06 08:03:57]

This can return a const String&

 
     CSSValue* value() const { return m_value.get(); }
 
     bool operator==(const MediaQueryExp& other) const
     {
-        return (other.m_mediaFeature == m_mediaFeature)
+        return (other.m_mediaFeatureHash == m_mediaFeatureHash)

[abarth-chromium, 2014/03/06 08:03:57]

Why do you need a hash?

Don't you need to check m_mediaFeature in addition to the hash?

             && ((!other.m_value && !m_value)
                 || (other.m_value && m_value && other.m_value->equals(*m_value)));
     }
 
     bool isViewportDependent() const;
 
     String serialize() const;
 
     PassOwnPtrWillBeRawPtr<MediaQueryExp> copy() const { return adoptPtrWillBeNoop(new MediaQueryExp(*this)); }
 
     void trace(Visitor* visitor) { visitor->trace(m_value); }
 
     MediaQueryExp(const MediaQueryExp& other);
 
 private:
-    MediaQueryExp(const AtomicString& mediaFeature, PassRefPtrWillBeRawPtr<CSSValue>);
+    MediaQueryExp(StringImpl*, PassRefPtrWillBeRawPtr<CSSValue>);

[abarth-chromium, 2014/03/06 08:03:57]

Why not const String& ?

 
-    AtomicString m_mediaFeature;
+    String m_mediaFeature;
+    unsigned m_mediaFeatureHash;

[abarth-chromium, 2014/03/06 08:03:57]

Is this needed for performance?

     RefPtrWillBeMember<CSSValue> m_value;
 };
 
 } // namespace
 
 #endif