Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Side by Side Diff: Source/core/css/MediaList.cpp

Issue 178803006: Turn MQ classes into thread safe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased after MediaFeature generation landed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/css/MediaQuery.h » ('j') | Source/core/css/MediaQuery.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2006, 2010, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2006, 2010, 2012 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 else if (value->isDotsPerCentimeter()) 259 else if (value->isDotsPerCentimeter())
260 message.append(String(mediaQueryMessage).replace("%replacementUnits%", m ediaValueDPCM).replace("%lengthUnit%", lengthUnitCentimeter)); 260 message.append(String(mediaQueryMessage).replace("%replacementUnits%", m ediaValueDPCM).replace("%lengthUnit%", lengthUnitCentimeter));
261 else 261 else
262 ASSERT_NOT_REACHED(); 262 ASSERT_NOT_REACHED();
263 263
264 message.append(serializedExpression); 264 message.append(serializedExpression);
265 265
266 document->addConsoleMessage(CSSMessageSource, DebugMessageLevel, message.toS tring()); 266 document->addConsoleMessage(CSSMessageSource, DebugMessageLevel, message.toS tring());
267 } 267 }
268 268
269 static inline bool isResolutionMediaFeature(const AtomicString& mediaFeature) 269 static inline bool isResolutionMediaFeature(const String& mediaFeature)
270 { 270 {
271 return mediaFeature == MediaFeatureNames::resolutionMediaFeature 271 return mediaFeature == MediaFeatureNames::resolutionMediaFeature
272 || mediaFeature == MediaFeatureNames::maxResolutionMediaFeature 272 || mediaFeature == MediaFeatureNames::maxResolutionMediaFeature
273 || mediaFeature == MediaFeatureNames::minResolutionMediaFeature; 273 || mediaFeature == MediaFeatureNames::minResolutionMediaFeature;
274 } 274 }
275 275
276 void reportMediaQueryWarningIfNeeded(Document* document, const MediaQuerySet* me diaQuerySet) 276 void reportMediaQueryWarningIfNeeded(Document* document, const MediaQuerySet* me diaQuerySet)
277 { 277 {
278 if (!mediaQuerySet || !document) 278 if (!mediaQuerySet || !document)
279 return; 279 return;
(...skipping 18 matching lines...) Expand all
298 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssV alue); 298 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssV alue);
299 if (primitiveValue->isDotsPerInch() || primitiveValue->isDot sPerCentimeter()) 299 if (primitiveValue->isDotsPerInch() || primitiveValue->isDot sPerCentimeter())
300 addResolutionWarningMessageToConsole(document, mediaQuer ySet->mediaText(), primitiveValue); 300 addResolutionWarningMessageToConsole(document, mediaQuer ySet->mediaText(), primitiveValue);
301 } 301 }
302 } 302 }
303 } 303 }
304 } 304 }
305 } 305 }
306 306
307 } 307 }
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/MediaQuery.h » ('j') | Source/core/css/MediaQuery.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698