third_party/WebKit/Source/platform/SharedBufferTest.cpp - Issue 1787973002: Replace blink::WebDiscardableMemory with base::DiscardableMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/SharedBufferTest.cpp

Issue 1787973002: Replace blink::WebDiscardableMemory with base::DiscardableMemory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use StringPiece::as_string Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/PurgeableVectorTest.cpp ('k') | third_party/WebKit/Source/platform/testing/RunAllTests.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/SharedBufferTest.cpp

diff --git a/third_party/WebKit/Source/platform/SharedBufferTest.cpp b/third_party/WebKit/Source/platform/SharedBufferTest.cpp

index 2178dddf7d3f2efd508bf6f144c576b66b7187b5..5dfda03d95418fbc32ee110b021e0ccbad8a0547 100644

--- a/third_party/WebKit/Source/platform/SharedBufferTest.cpp

+++ b/third_party/WebKit/Source/platform/SharedBufferTest.cpp

@@ -30,9 +30,9 @@

#include "platform/SharedBuffer.h"

-#include "platform/testing/TestingPlatformSupport.h"

-#include "public/platform/WebDiscardableMemory.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "wtf/OwnPtr.h"

+#include "wtf/PassOwnPtr.h"

#include "wtf/RefPtr.h"

#include "wtf/Vector.h"

#include <algorithm>

@@ -133,10 +133,6 @@ TEST(SharedBufferTest, createPurgeable)

Vector<char> testData(30000);

std::generate(testData.begin(), testData.end(), &std::rand);

- TestingPlatformSupport::Config config;

- config.hasDiscardableMemorySupport = true;

- TestingPlatformSupport platformWithDiscardableMemorySupport(config);

size_t length = testData.size();

RefPtr<SharedBuffer> sharedBuffer = SharedBuffer::createPurgeable(testData.data(), length);

ASSERT_EQ(length, sharedBuffer->size());