Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1787883005: Fix mini_installer to handle VS 2015 component builds (Closed)

Created:
4 years, 9 months ago by brucedawson
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, gab, stanisc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mini_installer to handle VS 2015 component builds The mini_installer needs to unpack more CRT DLLs now that we are using VS 2015. This change supports that, while still being VS 2013 compatible. TBR=gab@chromium.org BUG=594294 Committed: https://crrev.com/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4 Cr-Commit-Position: refs/heads/master@{#380833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/tools/build/win/create_installer_archive.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Dirk Pranke
lgtm, though I'm not an owner. maybe TBR gab@ or grt@ ?
4 years, 9 months ago (2016-03-12 01:12:04 UTC) #2
stanisc
lgtm I've tried Bruce's patch and verified that it works. The temp directory created by ...
4 years, 9 months ago (2016-03-12 01:17:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787883005/1
4 years, 9 months ago (2016-03-12 01:19:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-12 02:02:47 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4 Cr-Commit-Position: refs/heads/master@{#380833}
4 years, 9 months ago (2016-03-12 02:03:54 UTC) #12
vmiura
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1791483004/ by vmiura@chromium.org. ...
4 years, 9 months ago (2016-03-12 04:33:56 UTC) #13
gab
4 years, 9 months ago (2016-03-14 19:44:56 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698