Add SkSpecialImage::extractSubset & NewFromPixmap

Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch SkBlurImageFilter over to new onFilterImage interface)

This now relies on: https://codereview.chromium.org/1813483002/ (ImagePixelLocker now manually allocates SkPixmap) to clean up the uses of SkAutoPixmapStorage in Chromium

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1787883002

Committed: https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002

Committed: https://skia.googlesource.com/skia/+/c5035e70cc3fb290f95fd1c052c637aa0dbaf9ea

[robertphillips, 2016-03-11 21:24:05]

Description was changed from

==========
Add SkSpecialImage::extractSubset & NewFromPixmap
==========

to

==========
Add SkSpecialImage::extractSubset & NewFromPixmap
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-14 23:05:40]

Description was changed from

==========
Add SkSpecialImage::extractSubset & NewFromPixmap
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-14 23:05:40]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[robertphillips, 2016-03-14 23:13:43]

Description was changed from

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-03-15 03:13:03]

https://codereview.chromium.org/1787883002/diff/20001/include/core/SkPixmap.h
File include/core/SkPixmap.h (right):

https://codereview.chromium.org/1787883002/diff/20001/include/core/SkPixmap.h...
include/core/SkPixmap.h:225: void release();
Docs? What does this do differently from reset()?

[reed1, 2016-03-15 03:13:57]

side question: do we want to make SkAutoPixmapStorage internal only? Its
starting to get slightly sophisticated. Do we want to actually support it
publicly?

[bsalomon, 2016-03-16 13:50:15]

On 2016/03/15 03:13:57, reed1 wrote:
> side question: do we want to make SkAutoPixmapStorage internal only? Its
> starting to get slightly sophisticated. Do we want to actually support it
> publicly?

My instinct is "yes". It non-virtually overrides methods on SkPixmap. Seems like
it should have a flashing red warning above it. We could expose move the current
SkAPS::AllocSize (or a function that actually allocates that much) in SkPM as
that's helpful to clients.

[bsalomon, 2016-03-16 13:52:13]

https://codereview.chromium.org/1787883002/diff/20001/src/core/SkSpecialImage.h
File src/core/SkSpecialImage.h (right):

https://codereview.chromium.org/1787883002/diff/20001/src/core/SkSpecialImage...
src/core/SkSpecialImage.h:97: *  If the SpecialImage is backed by cpu pixels,
return the const address
and color table?

[robertphillips, 2016-03-16 15:31:59]

PTAL - I have hidden the SkAutoPixmapStorage.

https://codereview.chromium.org/1787883002/diff/20001/include/core/SkPixmap.h
File include/core/SkPixmap.h (right):

https://codereview.chromium.org/1787883002/diff/20001/include/core/SkPixmap.h...
include/core/SkPixmap.h:225: void release();
On 2016/03/15 03:13:03, reed1 wrote:
> Docs? What does this do differently from reset()?

Done.

https://codereview.chromium.org/1787883002/diff/20001/src/core/SkSpecialImage.h
File src/core/SkSpecialImage.h (right):

https://codereview.chromium.org/1787883002/diff/20001/src/core/SkSpecialImage...
src/core/SkSpecialImage.h:97: *  If the SpecialImage is backed by cpu pixels,
return the const address
On 2016/03/16 13:52:13, bsalomon wrote:
> and color table?

Done.

[reed1, 2016-03-16 15:55:17]

hiding lgtm

[bsalomon, 2016-03-16 15:56:18]

On 2016/03/16 15:55:17, reed1 wrote:
> hiding lgtm

lgtm

[robertphillips, 2016-03-16 16:01:05]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 16:01:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787883002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787883002/60001

[commit-bot: I haz the power, 2016-03-16 16:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 16:02:59]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2016-03-16 16:15:12]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 16:15:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787883002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787883002/80001

[commit-bot: I haz the power, 2016-03-16 16:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 16:29:30]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-16 16:45:49]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-03-16 16:45:49]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1787883002/#ps80001
(title: "Update to ToT")

[commit-bot: I haz the power, 2016-03-16 16:45:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787883002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787883002/80001

[commit-bot: I haz the power, 2016-03-16 16:47:23]

Description was changed from

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002
==========

[commit-bot: I haz the power, 2016-03-16 16:47:24]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002

[robertphillips, 2016-03-16 17:38:58]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1808833002/ by robertphillips@google.com.

The reason for reverting is: Need to wean ImagePixelLocker.h off of
SkAutoPixmapStorage :(.

[robertphillips, 2016-03-16 18:47:25]

Description was changed from

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002
==========

to

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002
==========

[robertphillips, 2016-03-17 13:27:06]

Description was changed from

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002
==========

to

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

This now relies on: https://codereview.chromium.org/1813483002/
(ImagePixelLocker now manually allocates SkPixmap) to clean up the uses of
SkAutoPixmapStorage in Chromium

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002
==========

[robertphillips, 2016-03-17 13:37:39]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 13:37:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787883002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787883002/80001

[commit-bot: I haz the power, 2016-03-17 13:38:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 13:38:38]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-17 13:57:24]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-03-17 13:57:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787883002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787883002/80001

[commit-bot: I haz the power, 2016-03-17 13:58:41]

Description was changed from

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

This now relies on: https://codereview.chromium.org/1813483002/
(ImagePixelLocker now manually allocates SkPixmap) to clean up the uses of
SkAutoPixmapStorage in Chromium

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002
==========

to

==========
Add SkSpecialImage::extractSubset & NewFromPixmap

This is calved off of: https://codereview.chromium.org/1785643003/ (Switch
SkBlurImageFilter over to new onFilterImage interface)

This now relies on: https://codereview.chromium.org/1813483002/
(ImagePixelLocker now manually allocates SkPixmap) to clean up the uses of
SkAutoPixmapStorage in Chromium

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/250581493a0859987e482810879e85e5ac2dc002

Committed:
https://skia.googlesource.com/skia/+/c5035e70cc3fb290f95fd1c052c637aa0dbaf9ea
==========

[commit-bot: I haz the power, 2016-03-17 13:58:43]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/c5035e70cc3fb290f95fd1c052c637aa0dbaf9ea