Fix up no gpu build

Fix up no gpu build

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1787843002

Committed: https://skia.googlesource.com/skia/+/4083610290308faae347ed94cf7aff9895af6289

[joshua.litt, 2016-03-11 18:57:19]

Description was changed from

==========
Fix up no gpu build

BUG=skia:
==========

to

==========
Fix up no gpu build

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-11 18:58:29]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-03-11 18:58:29]

ptal

[ethannicholas, 2016-03-11 19:21:38]

https://codereview.chromium.org/1787843002/diff/1/tools/skiaserve/Request.h
File tools/skiaserve/Request.h (right):

https://codereview.chromium.org/1787843002/diff/1/tools/skiaserve/Request.h#n...
tools/skiaserve/Request.h:72: GrContextFactory* fContextFactory;
Why this change? I mean, I see you're now cleaning it up in the destructor, but
I don't see why you didn't just continue using SkAutoTDelete.

[joshualitt, 2016-03-11 19:24:16]

On 2016/03/11 19:21:38, ethannicholas wrote:
> https://codereview.chromium.org/1787843002/diff/1/tools/skiaserve/Request.h
> File tools/skiaserve/Request.h (right):
> 
>
https://codereview.chromium.org/1787843002/diff/1/tools/skiaserve/Request.h#n...
> tools/skiaserve/Request.h:72: GrContextFactory* fContextFactory;
> Why this change? I mean, I see you're now cleaning it up in the destructor,
but
> I don't see why you didn't just continue using SkAutoTDelete.

I thought SkAutoTDelete needs to see the actual class declaration, maybe I'm
wrong.  I'll try to build with it and see what happens

[ethannicholas, 2016-03-11 19:29:54]

On 2016/03/11 19:24:16, joshualitt wrote:
> On 2016/03/11 19:21:38, ethannicholas wrote:
> > https://codereview.chromium.org/1787843002/diff/1/tools/skiaserve/Request.h
> > File tools/skiaserve/Request.h (right):
> > 
> >
>
https://codereview.chromium.org/1787843002/diff/1/tools/skiaserve/Request.h#n...
> > tools/skiaserve/Request.h:72: GrContextFactory* fContextFactory;
> > Why this change? I mean, I see you're now cleaning it up in the destructor,
> but
> > I don't see why you didn't just continue using SkAutoTDelete.
> 
> I thought SkAutoTDelete needs to see the actual class declaration, maybe I'm
> wrong.  I'll try to build with it and see what happens

No, you're right -- can't delete without knowing whether the destructor is
virtual. That was the part I missed. Carry on, lgtm :-)

[joshualitt, 2016-03-11 19:30:06]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-03-11 19:30:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787843002/1

[commit-bot: I haz the power, 2016-03-11 19:45:56]

Description was changed from

==========
Fix up no gpu build

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix up no gpu build

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/4083610290308faae347ed94cf7aff9895af6289
==========

[commit-bot: I haz the power, 2016-03-11 19:45:57]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4083610290308faae347ed94cf7aff9895af6289