Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1787803003: Improve used name relations and fields indexing. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve used name relations and fields indexing. I'm in the process of switching Analysis Server to the new index and found that we need these changes to make search tests pass. Refactorings don't need to know whether names are read or written, but users might (or might not) want to know this. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/30c49a0eab26b20745e92ebac17ac8961e8dde10

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -95 lines) Patch
M pkg/analysis_server/lib/src/services/index2/index2.dart View 5 chunks +27 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart View 3 chunks +29 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 3 chunks +20 lines, -14 lines 1 comment Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +22 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/index_unit.dart View 2 chunks +18 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/index_unit_test.dart View 4 chunks +70 lines, -57 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-11 17:54:14 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1787803003/diff/1/pkg/analysis_server/test/services/search/search_engine2_test.dart File pkg/analysis_server/test/services/search/search_engine2_test.dart (right): https://codereview.chromium.org/1787803003/diff/1/pkg/analysis_server/test/services/search/search_engine2_test.dart#newcode742 pkg/analysis_server/test/services/search/search_engine2_test.dart:742: ExpectedMatch _expectIdQ(Element element, MatchKind kind, String search, nit: ...
4 years, 9 months ago (2016-03-11 18:14:03 UTC) #2
scheglov
4 years, 9 months ago (2016-03-11 18:42:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30c49a0eab26b20745e92ebac17ac8961e8dde10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698