third_party/WebKit/Source/core/style/FillLayer.h - Issue 1787733003: Consolidate background fill layer opaqueness into one method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/FillLayer.h

Issue 1787733003: Consolidate background fill layer opaqueness into one method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: A new way to refactor Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPainter.cpp ('k') | third_party/WebKit/Source/core/style/FillLayer.cpp » ('j') | third_party/WebKit/Source/core/style/FillLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/FillLayer.h

diff --git a/third_party/WebKit/Source/core/style/FillLayer.h b/third_party/WebKit/Source/core/style/FillLayer.h

index 90e57fc190bed9cd70efb55baadde8ff9853beee..ab21981fca7fcd85b9a448870de69a67b7117c3f 100644

--- a/third_party/WebKit/Source/core/style/FillLayer.h

+++ b/third_party/WebKit/Source/core/style/FillLayer.h

@@ -175,7 +175,7 @@ public:

return m_next ? m_next->hasFixedImage() : false;

}

- bool hasOpaqueImage(const LayoutObject*) const;

+ bool imageOccludesNextLayers(const LayoutObject&) const;

Stephen Chennney 2016/03/16 20:54:16 Renamed to match the clipOccludesNextLayers method

bool hasRepeatXY() const;

bool clipOccludesNextLayers() const;

@@ -211,6 +211,8 @@ private:

FillLayer() { }

+ bool imageIsOpaqueAndTilesLayer(const LayoutObject&) const;

FillLayer* m_next;

RefPtrWillBePersistent<StyleImage> m_image;