Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: test/unittests/wasm/wasm-macro-gen-unittest.cc

Issue 1787733002: [wasm] Fix OpcodeLength() calculation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/wasm/wasm-macro-gen.h ('K') | « test/unittests/wasm/ast-decoder-unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/wasm/wasm-macro-gen-unittest.cc
diff --git a/test/unittests/wasm/wasm-macro-gen-unittest.cc b/test/unittests/wasm/wasm-macro-gen-unittest.cc
index 45e7b3983b3ceaaa3364387e5eb3e7f544499067..ed2fee65d01b5324f9020c95b2b4bb861b02d818 100644
--- a/test/unittests/wasm/wasm-macro-gen-unittest.cc
+++ b/test/unittests/wasm/wasm-macro-gen-unittest.cc
@@ -27,12 +27,16 @@ TEST_F(WasmMacroGenTest, Constants) {
EXPECT_SIZE(2, WASM_I8(254));
EXPECT_SIZE(2, WASM_I32V_1(1));
+ EXPECT_SIZE(3, WASM_I32V_2(200));
EXPECT_SIZE(4, WASM_I32V_3(10000));
EXPECT_SIZE(5, WASM_I32V_4(-9828934));
+ EXPECT_SIZE(6, WASM_I32V_5(-1119828934));
Mircea Trofin 2016/03/11 17:15:41 Do these numbers mean anything? Should they be a c
titzer 2016/03/11 17:17:35 They're just random values with no semantic meanin
EXPECT_SIZE(2, WASM_I64V_1(1));
+ EXPECT_SIZE(3, WASM_I64V_2(300));
EXPECT_SIZE(4, WASM_I64V_3(10000));
EXPECT_SIZE(5, WASM_I64V_4(-9828934));
+ EXPECT_SIZE(6, WASM_I64V_5(-1119828934));
EXPECT_SIZE(10, WASM_I64V_9(0x123456789abcdef0ULL));
EXPECT_SIZE(5, WASM_F32(1.0f));
« src/wasm/wasm-macro-gen.h ('K') | « test/unittests/wasm/ast-decoder-unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698