Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1787643003: Remove initializeWithoutV8 and shutdownWithoutV8 (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove initializeWithoutV8 and shutdownWithoutV8 Now initializeWithoutV8/shutdownWithoutV8 is idential to Platform::initialize/shutdown. This CL removes initializeWithoutV8/shutdownWithoutV8. BUG=593269 Committed: https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0 Cr-Commit-Position: refs/heads/master@{#380682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -39 lines) Patch
M components/test_runner/test_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ImageDecodeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebKit.h View 2 chunks +5 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
haraken
jochen@: PTAL
4 years, 9 months ago (2016-03-11 14:08:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-11 14:11:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787643003/1
4 years, 9 months ago (2016-03-11 14:11:55 UTC) #5
sof
Last car on this patch train? :)
4 years, 9 months ago (2016-03-11 14:17:08 UTC) #6
haraken
On 2016/03/11 14:17:08, sof wrote: > Last car on this patch train? :) Yes, mostly ...
4 years, 9 months ago (2016-03-11 14:19:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/195420)
4 years, 9 months ago (2016-03-11 16:22:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787643003/1
4 years, 9 months ago (2016-03-11 16:23:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 18:40:30 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 18:42:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0
Cr-Commit-Position: refs/heads/master@{#380682}

Powered by Google App Engine
This is Rietveld 408576698