Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3814)

Unified Diff: chrome/browser/android/most_visited_sites.h

Issue 1787633002: Use whitelist large icon for corresponding most visited suggestions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@icon-whitelist
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/most_visited_sites.h
diff --git a/chrome/browser/android/most_visited_sites.h b/chrome/browser/android/most_visited_sites.h
index 4a44b6badbd079d72ef855b09e766dc7bacb729b..6a74f01c85611f3cd188bd8814e3cd6bdcc447c1 100644
--- a/chrome/browser/android/most_visited_sites.h
+++ b/chrome/browser/android/most_visited_sites.h
@@ -90,24 +90,27 @@ class MostVisitedSites : public sync_driver::SyncServiceObserver,
base::string16 title;
GURL url;
MostVisitedSource source;
- // Only valid for source == WHITELIST (empty otherwise).
+ // Will be empty for entries that do not have a whitelist associated with
Marc Treib 2016/03/11 14:21:01 nit: "that don't have an associated whitelist", th
atanasova 2016/03/11 15:59:25 Done.
+ // them.
base::FilePath large_icon_path;
// Only valid for source == SUGGESTIONS_SERVICE (-1 otherwise).
int provider_index;
Suggestion(const base::string16& title,
- const std::string& url,
+ const GURL& url,
MostVisitedSource source);
Suggestion(const base::string16& title,
- const GURL& url,
+ const std::string& url,
MostVisitedSource source,
const base::FilePath& large_icon_path);
Suggestion(const base::string16& title,
const GURL& url,
- MostVisitedSource source);
+ MostVisitedSource source,
+ const base::FilePath& large_icon_path);
Suggestion(const base::string16& title,
const std::string& url,
MostVisitedSource source,
+ const base::FilePath& large_icon_path,
int provider_index);
~Suggestion();
@@ -127,6 +130,9 @@ class MostVisitedSites : public sync_driver::SyncServiceObserver,
// enabled, or if it returns no data.
void InitiateTopSitesQuery();
+ // If there is a whitelist entry point for the URL return the large icon path
+ base::FilePath GetWhitelistLargeIconPath(const GURL& url);
+
// Callback for when data is available from TopSites.
void OnMostVisitedURLsAvailable(
const history::MostVisitedURLList& visited_list);
« no previous file with comments | « no previous file | chrome/browser/android/most_visited_sites.cc » ('j') | chrome/browser/android/most_visited_sites.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698