Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2394)

Unified Diff: Source/modules/mediasource/WebKitSourceBuffer.cpp

Issue 178763006: Enable round-tripping and updating of SourceBuffer timestamp offset (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase and rework so WSB::append() indicates updated timestamp offset Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediasource/WebKitSourceBuffer.cpp
diff --git a/Source/modules/mediasource/WebKitSourceBuffer.cpp b/Source/modules/mediasource/WebKitSourceBuffer.cpp
index f460311fb3dc0bea48d95d62227b62850ebe8afb..1332e277eebb5d20b4fd1a0abb843e33b97d210d 100644
--- a/Source/modules/mediasource/WebKitSourceBuffer.cpp
+++ b/Source/modules/mediasource/WebKitSourceBuffer.cpp
@@ -136,7 +136,10 @@ void WebKitSourceBuffer::append(PassRefPtr<Uint8Array> data, ExceptionState& exc
m_source->openIfInEndedState();
// Steps 6 & beyond are handled by m_webSourceBuffer.
- m_webSourceBuffer->append(data->data(), data->length());
+
+ // Only "sequence" mode coded frame processing, not in prefixed API, may update timestamp offset.
acolwell GONE FROM CHROMIUM 2014/02/27 01:24:45 nit: This comment is a little confusing. How about
wolenetz 2014/02/27 01:44:56 Done.
+ double dummyNewTimestampOffset;
+ m_webSourceBuffer->append(data->data(), data->length(), &dummyNewTimestampOffset);
}
void WebKitSourceBuffer::abort(ExceptionState& exceptionState)

Powered by Google App Engine
This is Rietveld 408576698