Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Unified Diff: Source/modules/mediasource/SourceBuffer.cpp

Issue 178763006: Enable round-tripping and updating of SourceBuffer timestamp offset (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediasource/SourceBuffer.cpp
diff --git a/Source/modules/mediasource/SourceBuffer.cpp b/Source/modules/mediasource/SourceBuffer.cpp
index 64e8021bd5204ef9799a3085f9a849c9b44815d9..8a3a8acfed9b669a7f627468c76f9fcbfcfd5a77 100644
--- a/Source/modules/mediasource/SourceBuffer.cpp
+++ b/Source/modules/mediasource/SourceBuffer.cpp
@@ -538,6 +538,10 @@ void SourceBuffer::appendBufferAsyncPart()
}
m_webSourceBuffer->append(m_pendingAppendData.data(), appendSize);
+ // Update our cached |m_timestampOffset| since the implementation may change
+ // it during append() processing.
+ m_timestampOffset = m_webSourceBuffer->getTimestampOffset();
acolwell GONE FROM CHROMIUM 2014/02/25 17:50:57 See my comments in the Chromium-side changes. I th
wolenetz 2014/02/25 20:33:32 Done.
+
// 3. Set the updating attribute to false.
m_updating = false;
m_pendingAppendData.clear();
@@ -692,6 +696,10 @@ void SourceBuffer::didReceiveDataForClient(const char* data, unsigned dataLength
ASSERT(m_loader);
m_webSourceBuffer->append(reinterpret_cast<const unsigned char*>(data), dataLength);
+
+ // Update our cached |m_timestampOffset| since the implementation may change
+ // it during append() processing.
+ m_timestampOffset = m_webSourceBuffer->getTimestampOffset();
acolwell GONE FROM CHROMIUM 2014/02/25 17:50:57 ditto. Perhaps put the update logic in a updateTim
wolenetz 2014/02/25 20:33:32 Done.
}
void SourceBuffer::didFinishLoading()

Powered by Google App Engine
This is Rietveld 408576698