Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: Source/modules/mediasource/WebKitSourceBuffer.cpp

Issue 178763006: Enable round-tripping and updating of SourceBuffer timestamp offset (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 if (throwExceptionIfRemoved(isRemoved(), exceptionState)) 132 if (throwExceptionIfRemoved(isRemoved(), exceptionState))
133 return; 133 return;
134 134
135 // 5. If the readyState attribute of media source is in the "ended" state th en run the following steps: 135 // 5. If the readyState attribute of media source is in the "ended" state th en run the following steps:
136 // 5.1. Set the readyState attribute of media source to "open" 136 // 5.1. Set the readyState attribute of media source to "open"
137 // 5.2. Queue a task to fire a simple event named sourceopen at media source . 137 // 5.2. Queue a task to fire a simple event named sourceopen at media source .
138 m_source->openIfInEndedState(); 138 m_source->openIfInEndedState();
139 139
140 // Steps 6 & beyond are handled by m_webSourceBuffer. 140 // Steps 6 & beyond are handled by m_webSourceBuffer.
141 m_webSourceBuffer->append(data->data(), data->length()); 141 m_webSourceBuffer->append(data->data(), data->length());
142
143 // Retrieve the implementation's possibly updated timestamp offset resulting
144 // from the append. In reality, since this prefixed API does not support
145 // "sequence" append mode, the offset should not have changed due to
146 // append processing.
147 m_timestampOffset = m_webSourceBuffer->getTimestampOffset();
acolwell GONE FROM CHROMIUM 2014/02/25 17:50:57 Remove this. As your comment states, the timestamp
wolenetz 2014/02/25 20:33:32 Done.
142 } 148 }
143 149
144 void WebKitSourceBuffer::abort(ExceptionState& exceptionState) 150 void WebKitSourceBuffer::abort(ExceptionState& exceptionState)
145 { 151 {
146 // Section 3.2 abort() method steps. 152 // Section 3.2 abort() method steps.
147 // 1. If this object has been removed from the sourceBuffers attribute of th e parent media source 153 // 1. If this object has been removed from the sourceBuffers attribute of th e parent media source
148 // then throw an InvalidStateError exception and abort these steps. 154 // then throw an InvalidStateError exception and abort these steps.
149 // 2. If the readyState attribute of the parent media source is not in the " open" state 155 // 2. If the readyState attribute of the parent media source is not in the " open" state
150 // then throw an InvalidStateError exception and abort these steps. 156 // then throw an InvalidStateError exception and abort these steps.
151 if (throwExceptionIfRemoved(isRemoved(), exceptionState)) 157 if (throwExceptionIfRemoved(isRemoved(), exceptionState))
(...skipping 20 matching lines...) Expand all
172 { 178 {
173 return !m_source; 179 return !m_source;
174 } 180 }
175 181
176 void WebKitSourceBuffer::trace(Visitor* visitor) 182 void WebKitSourceBuffer::trace(Visitor* visitor)
177 { 183 {
178 visitor->trace(m_source); 184 visitor->trace(m_source);
179 } 185 }
180 186
181 } // namespace WebCore 187 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698