win_toolchain/get_toolchain_if_necessary.py - Issue 178763003: Don't have svn ls block waiting for password

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win_toolchain/get_toolchain_if_necessary.py

Issue 178763003: Don't have svn ls block waiting for password (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: reitveld Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: win_toolchain/get_toolchain_if_necessary.py

diff --git a/win_toolchain/get_toolchain_if_necessary.py b/win_toolchain/get_toolchain_if_necessary.py

index fb18ffc43921dad050faf0b66a6b6911d58cbabb..033c091018fb3e25bd9084b180403d2d76e138fa 100755

--- a/win_toolchain/get_toolchain_if_necessary.py

+++ b/win_toolchain/get_toolchain_if_necessary.py

@@ -121,7 +121,7 @@ def HaveSrcInternalAccess():

"""Checks whether access to src-internal is available."""

with open(os.devnull, 'w') as nul:

if subprocess.call(

- ['svn', 'ls',

+ ['svn', 'ls', '--non-interactive',

'svn://svn.chromium.org/chrome-internal/trunk/src-internal/'],

shell=True, stdin=nul, stdout=nul, stderr=nul) == 0:

return True

« no previous file with comments | « no previous file | no next file » | no next file with comments »