Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 178763003: Don't have svn ls block waiting for password (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Don't have svn ls block waiting for password If user is unauthenticated, svn ls would just hang waiting at "Password for 'User':", now it'll correctly fail with "svn: Can't get password". R=iannucci@chromium.org BUG=323300, 346472 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=253004

Patch Set 1 #

Patch Set 2 : reitveld #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 10 months ago (2014-02-24 21:58:22 UTC) #1
iannucci
A Trap it is. lgtm
6 years, 10 months ago (2014-02-24 22:05:26 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-24 22:05:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/178763003/20001
6 years, 10 months ago (2014-02-24 22:06:06 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 22:08:10 UTC) #5
Message was sent while issue was closed.
Change committed as 253004

Powered by Google App Engine
This is Rietveld 408576698