Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1787623005: Add more debugging code (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +36 lines, -1 line 2 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-11 18:53:00 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1787623005/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1787623005/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode5154 pkg/analyzer/lib/src/task/dart.dart:5154: 'VerifyUnitTask verifying constants in a unit with no ...
4 years, 9 months ago (2016-03-11 18:57:12 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1787623005/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1787623005/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode5154 pkg/analyzer/lib/src/task/dart.dart:5154: 'VerifyUnitTask verifying constants in a unit with no library: ...
4 years, 9 months ago (2016-03-11 19:04:54 UTC) #4
Brian Wilkerson
4 years, 9 months ago (2016-03-11 19:05:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f4eb824d4e550ca57252a57a5ae630247197ce3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698