Move LSan-specific shutdown code to ThreadState::cleanupMainThread

Move LSan-specific shutdown code to ThreadState::cleanupMainThread

BUG=593269
Committed: https://crrev.com/45bafe4e8cdbc6185f133892b4fe57fe372b3fe2
Cr-Commit-Position: refs/heads/master@{#380621}

[haraken, 2016-03-11 09:18:05]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-03-11 09:18:05]

PTAL

https://codereview.chromium.org/1787623003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/1787623003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.cpp:219: // followed by GCs
to clear out all they referred to.

I forgot the details about this.

Why is it okay to not trigger V8 GCs after Heap::collectAllGarbage()?

[sof, 2016-03-11 09:36:18]

lgtm

I sure wouldn't mind if this was tested w/ LSan before landing.

https://codereview.chromium.org/1787623003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right):

https://codereview.chromium.org/1787623003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/ThreadState.cpp:219: // followed by GCs
to clear out all they referred to.
On 2016/03/11 09:18:05, haraken wrote:
> 
> I forgot the details about this.
> 
> Why is it okay to not trigger V8 GCs after Heap::collectAllGarbage()?
> 

For the purposes of overall leak detection, we are relying on the v8 heap having
been GCed separately & I don't think they would be holding onto the same set of
objects as these singletons.

[haraken, 2016-03-11 09:41:13]

> I sure wouldn't mind if this was tested w/ LSan before landing.
> 
>
https://codereview.chromium.org/1787623003/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/heap/ThreadState.cpp (right):
> 
>
https://codereview.chromium.org/1787623003/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/heap/ThreadState.cpp:219: // followed by
GCs
> to clear out all they referred to.
> On 2016/03/11 09:18:05, haraken wrote:
> > 
> > I forgot the details about this.
> > 
> > Why is it okay to not trigger V8 GCs after Heap::collectAllGarbage()?
> > 
> 
> For the purposes of overall leak detection, we are relying on the v8 heap
having
> been GCed separately & I don't think they would be holding onto the same set
of
> objects as these singletons.

OK, the assumption is that these persistent handles do not hold objects on the
v8 heap. Makes sense.

[haraken, 2016-03-11 09:41:16]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-03-11 09:41:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787623003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787623003/1

[commit-bot: I haz the power, 2016-03-11 11:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 11:13:53]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-03-11 12:47:09]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-03-11 12:47:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787623003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787623003/1

[commit-bot: I haz the power, 2016-03-11 13:38:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-11 13:40:06]

Description was changed from

==========
Move LSan-specific shutdown code to ThreadState::cleanupMainThread

BUG=593269
==========

to

==========
Move LSan-specific shutdown code to ThreadState::cleanupMainThread

BUG=593269

Committed: https://crrev.com/45bafe4e8cdbc6185f133892b4fe57fe372b3fe2
Cr-Commit-Position: refs/heads/master@{#380621}
==========

[commit-bot: I haz the power, 2016-03-11 13:40:07]

Patchset 1 (id:??) landed as
https://crrev.com/45bafe4e8cdbc6185f133892b4fe57fe372b3fe2
Cr-Commit-Position: refs/heads/master@{#380621}