chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm - Issue 1787553003: mac: Remove uses of a CoreGraphics private API that causes WindowServer crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

Issue 1787553003: mac: Remove uses of a CoreGraphics private API that causes WindowServer crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add semicolons. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

index 4685a25b07c4825e3b9c335c2fffeda0409b0a13..02bcb6e9e64b83b66358f560ecfced2356cbd5db 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

@@ -60,6 +60,10 @@ ExtensionInstallDialogController::ExtensionInstallDialogController(

base::scoped_nsobject<CustomConstrainedWindowSheet> sheet(

[[CustomConstrainedWindowSheet alloc] initWithCustomWindow:window]);

+ // The extension install dialog can cause window server crashes when using the

+ // complex animations provided by private APIs, so use simple animations. See

+ // https://crbug.com/548824.

+ [sheet setUseSimpleAnimations:YES];

constrained_window_ = CreateAndShowWebModalDialogMac(

this, show_params->GetParentWebContents(), sheet);

« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm ('k') | no next file » | no next file with comments »