chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h - Issue 1787553003: mac: Remove uses of a CoreGraphics private API that causes WindowServer crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h

Issue 1787553003: mac: Remove uses of a CoreGraphics private API that causes WindowServer crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tapted. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm » ('j') | chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h b/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h

index de54a819080f039256f38b71368c7e96dc8a58de..159b33c4735759edeefcd68f75dcf536148792fa 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h

@@ -15,10 +15,16 @@

@interface CustomConstrainedWindowSheet : NSObject<ConstrainedWindowSheet> {

@protected

base::scoped_nsobject<NSWindow> customWindow_;

+ BOOL useSimpleAnimations_;

}

- (id)initWithCustomWindow:(NSWindow*)customWindow;

+// Defaults to NO.

+// The standard animation uses private CGS APIs, which can crash the window

+// server. https://crbug.com/515627#c75

+- (void)setUseSimpleAnimations:(BOOL)simpleAnimations;

@end

#endif // CHROME_BROWSER_UI_COCOA_CONSTRAINED_WINDOW_CONSTRAINED_WINDOW_CUSTOM_SHEET_H_