Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1787513004: Move grid-auto-flow into CSSPropertyParser (Closed)

Created:
4 years, 9 months ago by rwlbuis
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move grid-auto-flow into CSSPropertyParser Move the grid-auto-flow longhand from LegacyCSSPropertyParser into CSSPropertyParser. Make the grid shorthand parsing code use this new code path (this means it does not use CSSParserValue anymore). BUG=499780 Committed: https://crrev.com/762506c50ebe7cf500c13f54d002f50e0cc17ace Cr-Commit-Position: refs/heads/master@{#386668}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase again #

Patch Set 4 : Fix test #

Patch Set 5 : Fix test expectation #

Total comments: 1

Patch Set 6 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -376 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 6 chunks +2 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 4 3 chunks +21 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 4 5 8 chunks +15 lines, -319 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rwlbuis
PTAL. The test expectation is changed, since for dense|row|column we do not add the first ...
4 years, 8 months ago (2016-04-11 21:14:07 UTC) #5
Timothy Loh
lgtm https://codereview.chromium.org/1787513004/diff/80001/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp (right): https://codereview.chromium.org/1787513004/diff/80001/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp#newcode117 third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp:117: addProperty(CSSPropertyGridAutoFlow, gridAutoFlow, important); imo nicer to put this ...
4 years, 8 months ago (2016-04-12 05:31:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787513004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787513004/100001
4 years, 8 months ago (2016-04-12 12:06:46 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-12 13:31:00 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 13:32:12 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/762506c50ebe7cf500c13f54d002f50e0cc17ace
Cr-Commit-Position: refs/heads/master@{#386668}

Powered by Google App Engine
This is Rietveld 408576698