Issue 17875002: Revert "CPUProfiler: Simplify CodeEntry constructor calls."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17875002: Revert "CPUProfiler: Simplify CodeEntry constructor calls." (Closed)

Created:
7 years, 6 months ago by loislo

Modified:
7 years, 6 months ago

Reviewers:
yurys

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "CPUProfiler: Simplify CodeEntry constructor calls." This reverts commit a6cc1e3b563c0d0689da35dbf8163545c8146ddd. One test starts failing on Windows. BUG=none TBR= yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15335

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -36 lines)			Patch
M	src/profile-generator.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/profile-generator.cc	View	5 chunks	+16 lines, -4 lines	0 comments	Download
M	src/profile-generator-inl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-profile-generator.cc	View	11 chunks	+49 lines, -27 lines	0 comments	Download

Total messages: 1 (0 generated)

loislo

7 years, 6 months ago (2013-06-26 12:38:20 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r15335 (presubmit successful).