Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: net/quic/quic_protocol.cc

Issue 1787443002: Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116391846
Patch Set: Removed revived packet from QuicConnectionLogger Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_received_packet_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_protocol.h" 5 #include "net/quic/quic_protocol.h"
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "net/quic/quic_flags.h" 8 #include "net/quic/quic_flags.h"
9 #include "net/quic/quic_utils.h" 9 #include "net/quic/quic_utils.h"
10 10
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 QuicStopWaitingFrame::QuicStopWaitingFrame() 281 QuicStopWaitingFrame::QuicStopWaitingFrame()
282 : path_id(kDefaultPathId), entropy_hash(0), least_unacked(0) {} 282 : path_id(kDefaultPathId), entropy_hash(0), least_unacked(0) {}
283 283
284 QuicStopWaitingFrame::~QuicStopWaitingFrame() {} 284 QuicStopWaitingFrame::~QuicStopWaitingFrame() {}
285 285
286 QuicAckFrame::QuicAckFrame() 286 QuicAckFrame::QuicAckFrame()
287 : path_id(kDefaultPathId), 287 : path_id(kDefaultPathId),
288 entropy_hash(0), 288 entropy_hash(0),
289 is_truncated(false), 289 is_truncated(false),
290 largest_observed(0), 290 largest_observed(0),
291 ack_delay_time(QuicTime::Delta::Infinite()), 291 ack_delay_time(QuicTime::Delta::Infinite()) {}
292 latest_revived_packet(0) {}
293 292
294 QuicAckFrame::QuicAckFrame(const QuicAckFrame& other) = default; 293 QuicAckFrame::QuicAckFrame(const QuicAckFrame& other) = default;
295 294
296 QuicAckFrame::~QuicAckFrame() {} 295 QuicAckFrame::~QuicAckFrame() {}
297 296
298 QuicRstStreamErrorCode AdjustErrorForVersion(QuicRstStreamErrorCode error_code, 297 QuicRstStreamErrorCode AdjustErrorForVersion(QuicRstStreamErrorCode error_code,
299 QuicVersion /*version*/) { 298 QuicVersion /*version*/) {
300 return error_code; 299 return error_code;
301 } 300 }
302 301
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 } 517 }
519 return os; 518 return os;
520 } 519 }
521 520
522 ostream& operator<<(ostream& os, const QuicAckFrame& ack_frame) { 521 ostream& operator<<(ostream& os, const QuicAckFrame& ack_frame) {
523 os << "entropy_hash: " << static_cast<int>(ack_frame.entropy_hash) 522 os << "entropy_hash: " << static_cast<int>(ack_frame.entropy_hash)
524 << " largest_observed: " << ack_frame.largest_observed 523 << " largest_observed: " << ack_frame.largest_observed
525 << " ack_delay_time: " << ack_frame.ack_delay_time.ToMicroseconds() 524 << " ack_delay_time: " << ack_frame.ack_delay_time.ToMicroseconds()
526 << " missing_packets: [ " << ack_frame.missing_packets 525 << " missing_packets: [ " << ack_frame.missing_packets
527 << " ] is_truncated: " << ack_frame.is_truncated 526 << " ] is_truncated: " << ack_frame.is_truncated
528 << " revived_packet: " << ack_frame.latest_revived_packet
529 << " received_packets: [ "; 527 << " received_packets: [ ";
530 for (const std::pair<QuicPacketNumber, QuicTime>& p : 528 for (const std::pair<QuicPacketNumber, QuicTime>& p :
531 ack_frame.received_packet_times) { 529 ack_frame.received_packet_times) {
532 os << p.first << " at " << p.second.ToDebuggingValue() << " "; 530 os << p.first << " at " << p.second.ToDebuggingValue() << " ";
533 } 531 }
534 os << " ]"; 532 os << " ]";
535 return os; 533 return os;
536 } 534 }
537 535
538 ostream& operator<<(ostream& os, const QuicFrame& frame) { 536 ostream& operator<<(ostream& os, const QuicFrame& frame) {
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 is_fec_packet(is_fec_packet), 788 is_fec_packet(is_fec_packet),
791 has_crypto_handshake(has_crypto_handshake), 789 has_crypto_handshake(has_crypto_handshake),
792 needs_padding(needs_padding), 790 needs_padding(needs_padding),
793 retransmission(0) {} 791 retransmission(0) {}
794 792
795 TransmissionInfo::TransmissionInfo(const TransmissionInfo& other) = default; 793 TransmissionInfo::TransmissionInfo(const TransmissionInfo& other) = default;
796 794
797 TransmissionInfo::~TransmissionInfo() {} 795 TransmissionInfo::~TransmissionInfo() {}
798 796
799 } // namespace net 797 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_received_packet_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698