Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1787423007: Android: use chromium clang plugins in gn build (Closed)

Created:
4 years, 9 months ago by boliu
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: use chromium clang plugins in gn build BUG=594576 Committed: https://crrev.com/1131c627f1a8489711b173f683e3c3d43542fe2b Cr-Commit-Position: refs/heads/master@{#381038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/clang/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
ptal There is no gn+clang android bots yet I think? But at least locally this ...
4 years, 9 months ago (2016-03-14 16:22:50 UTC) #2
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-14 18:39:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787423007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787423007/1
4 years, 9 months ago (2016-03-14 18:41:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 19:24:02 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 19:25:36 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1131c627f1a8489711b173f683e3c3d43542fe2b
Cr-Commit-Position: refs/heads/master@{#381038}

Powered by Google App Engine
This is Rietveld 408576698