Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1787173003: Add builder for recipe roll tryjob. (Closed)

Created:
4 years, 9 months ago by estaab
Modified:
4 years, 9 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add builder for recipe roll tryjob. Depends on http://crrev.com/1758523002. BUG=594265 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299367

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bad properties. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M masters/master.tryserver.infra/builders.pyl View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
estaab
4 years, 9 months ago (2016-03-12 18:05:34 UTC) #2
martiniss
https://codereview.chromium.org/1787173003/diff/1/masters/master.tryserver.infra/builders.pyl File masters/master.tryserver.infra/builders.pyl (right): https://codereview.chromium.org/1787173003/diff/1/masters/master.tryserver.infra/builders.pyl#newcode224 masters/master.tryserver.infra/builders.pyl:224: "properties": { What are these properties supposed to do? ...
4 years, 9 months ago (2016-03-12 18:33:47 UTC) #3
estaab
https://codereview.chromium.org/1787173003/diff/1/masters/master.tryserver.infra/builders.pyl File masters/master.tryserver.infra/builders.pyl (right): https://codereview.chromium.org/1787173003/diff/1/masters/master.tryserver.infra/builders.pyl#newcode224 masters/master.tryserver.infra/builders.pyl:224: "properties": { On 2016/03/12 at 18:33:47, martiniss wrote: > ...
4 years, 9 months ago (2016-03-12 18:39:54 UTC) #4
martiniss
lgtm
4 years, 9 months ago (2016-03-16 23:06:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787173003/20001
4 years, 9 months ago (2016-03-16 23:06:46 UTC) #7
estaab
On 2016/03/16 at 23:06:46, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 9 months ago (2016-03-16 23:08:10 UTC) #9
martiniss
On 2016/03/16 at 23:08:10, estaab wrote: > On 2016/03/16 at 23:06:46, commit-bot wrote: > > ...
4 years, 9 months ago (2016-03-16 23:59:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787173003/20001
4 years, 9 months ago (2016-03-17 21:55:07 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 21:58:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299367

Powered by Google App Engine
This is Rietveld 408576698