Subzero: Allow Makefile.standalone to build for a single target.

Subzero: Allow Makefile.standalone to build for a single target.

This makes it easier to focus on reducing the translator size.

Enable with e.g.:
  make -f Makefile.standalone MINIMAL=1 SZTARGET=X8664 bloat-sb

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4362
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=999a22f0bbd828c9fc711b6100194f0678d1a08c

[Jim Stichnoth, 2016-03-12 15:40:21]

Description was changed from

==========
Subzero: Allow Makefile.standalone to build for a single target.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4362
==========

to

==========
Subzero: Allow Makefile.standalone to build for a single target.

This makes it easier to focus on reducing the translator size.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4362
==========

[Jim Stichnoth, 2016-03-12 15:40:21]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Jim Stichnoth, 2016-03-12 15:50:57]

Description was changed from

==========
Subzero: Allow Makefile.standalone to build for a single target.

This makes it easier to focus on reducing the translator size.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4362
==========

to

==========
Subzero: Allow Makefile.standalone to build for a single target.

This makes it easier to focus on reducing the translator size.

Enable with e.g.:
  make -f Makefile.standalone MINIMAL=1 SZTARGET=X8664 bloat-sb

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4362
==========

[John, 2016-03-12 17:43:13]

lgtm

https://codereview.chromium.org/1787143002/diff/1/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/1787143002/diff/1/Makefile.standalone#newcode104
Makefile.standalone:104: #   SZTARGET=ARM32
what do you think about adding a comment to Makefile.standalone-help/help.txt as
well?

https://codereview.chromium.org/1787143002/diff/1/src/IceTargetLowering.cpp
File src/IceTargetLowering.cpp (right):

https://codereview.chromium.org/1787143002/diff/1/src/IceTargetLowering.cpp#n...
src/IceTargetLowering.cpp:30: #define CONCAT_TOKENS(a, b) a##b
This is always invoked as

CONCAT_TOKENS(Target_, X)

maybe having something like

TARGET_LOWERING_CLASS_FOR(X) Target_##X

would be clearer?

[Jim Stichnoth, 2016-03-12 18:22:44]

https://codereview.chromium.org/1787143002/diff/1/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/1787143002/diff/1/Makefile.standalone#newcode104
Makefile.standalone:104: #   SZTARGET=ARM32
On 2016/03/12 17:43:13, John wrote:
> what do you think about adding a comment to Makefile.standalone-help/help.txt
as
> well?

Good idea, done.

https://codereview.chromium.org/1787143002/diff/1/src/IceTargetLowering.cpp
File src/IceTargetLowering.cpp (right):

https://codereview.chromium.org/1787143002/diff/1/src/IceTargetLowering.cpp#n...
src/IceTargetLowering.cpp:30: #define CONCAT_TOKENS(a, b) a##b
On 2016/03/12 17:43:13, John wrote:
> This is always invoked as
> 
> CONCAT_TOKENS(Target_, X)
> 
> maybe having something like
> 
> TARGET_LOWERING_CLASS_FOR(X) Target_##X
> 
> would be clearer?

Done.

[Jim Stichnoth, 2016-03-12 18:22:57]

Description was changed from

==========
Subzero: Allow Makefile.standalone to build for a single target.

This makes it easier to focus on reducing the translator size.

Enable with e.g.:
  make -f Makefile.standalone MINIMAL=1 SZTARGET=X8664 bloat-sb

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4362
==========

to

==========
Subzero: Allow Makefile.standalone to build for a single target.

This makes it easier to focus on reducing the translator size.

Enable with e.g.:
  make -f Makefile.standalone MINIMAL=1 SZTARGET=X8664 bloat-sb

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4362
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-03-12 18:22:59]

Committed patchset #3 (id:40001) manually as
999a22f0bbd828c9fc711b6100194f0678d1a08c (presubmit successful).