Use chrome manifest with embedded shell

Use chrome manifest with embedded shell

Moves chrome_manifest.json out of chrome/app/mash
and into content/browser. Changes Shell to use the
resolver when connecting to exe:chrome even when
embedded in the browser.

This brings embedded and external shell behavior
closer together as the manifest will now be used
for the browser app both in and out of mash.

As such, it fixes the fact that the browser cannot
currently connect to exe:chrome_renderer due to
recent changes around capability classes and client
process connections.

BUG=None

Committed: https://crrev.com/90f8fccd97c06ddfd0c0e9b7350a4f7fffccfb36
Cr-Commit-Position: refs/heads/master@{#380913}

[Ken Rockot(use gerrit already), 2016-03-13 00:23:03]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ben Goodger (Google), 2016-03-13 01:14:42]

I'm puzzled by the extra parameter to Connect(), since you don't use it in this
CL...

[Ken Rockot(use gerrit already), 2016-03-13 01:17:42]

On 2016/03/13 at 01:14:42, ben wrote:
> I'm puzzled by the extra parameter to Connect(), since you don't use it in
this CL...

It's used by InitInstanceForEmbedder

[Ben Goodger (Google), 2016-03-13 01:36:15]

On 2016/03/13 01:17:42, Ken Rockot wrote:
> On 2016/03/13 at 01:14:42, ben wrote:
> > I'm puzzled by the extra parameter to Connect(), since you don't use it in
> this CL...
> 
> It's used by InitInstanceForEmbedder

What do you get by having that code go thru Connect() vs. CreateInstance?

[Ken Rockot(use gerrit already), 2016-03-13 01:38:57]

Catalog behavior, which will load the right manifest for the embedder's
name. So we get capabilities etc from chrome_manifest.json when using the
emebedded shell.

On Sat, Mar 12, 2016 at 5:36 PM, <ben@chromium.org> wrote:

> On 2016/03/13 01:17:42, Ken Rockot wrote:
> > On 2016/03/13 at 01:14:42, ben wrote:
> > > I'm puzzled by the extra parameter to Connect(), since you don't use
> it in
> > this CL...
> >
> > It's used by InitInstanceForEmbedder
>
> What do you get by having that code go thru Connect() vs. CreateInstance?
>
> https://codereview.chromium.org/1787083003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2016-03-13 04:18:01]

Ah. lgtm

[Ken Rockot(use gerrit already), 2016-03-14 00:55:45]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-03-14 00:55:45]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1787083003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-14 00:55:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787083003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787083003/60001

[commit-bot: I haz the power, 2016-03-14 01:00:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-14 01:02:02]

Description was changed from

==========
Use chrome manifest with embedded shell

Moves chrome_manifest.json out of chrome/app/mash
and into content/browser. Changes Shell to use the
resolver when connecting to exe:chrome even when
embedded in the browser.

This brings embedded and external shell behavior
closer together as the manifest will now be used
for the browser app both in and out of mash.

As such, it fixes the fact that the browser cannot
currently connect to exe:chrome_renderer due to
recent changes around capability classes and client
process connections.

BUG=None
==========

to

==========
Use chrome manifest with embedded shell

Moves chrome_manifest.json out of chrome/app/mash
and into content/browser. Changes Shell to use the
resolver when connecting to exe:chrome even when
embedded in the browser.

This brings embedded and external shell behavior
closer together as the manifest will now be used
for the browser app both in and out of mash.

As such, it fixes the fact that the browser cannot
currently connect to exe:chrome_renderer due to
recent changes around capability classes and client
process connections.

BUG=None

Committed: https://crrev.com/90f8fccd97c06ddfd0c0e9b7350a4f7fffccfb36
Cr-Commit-Position: refs/heads/master@{#380913}
==========

[commit-bot: I haz the power, 2016-03-14 01:02:04]

Patchset 4 (id:??) landed as
https://crrev.com/90f8fccd97c06ddfd0c0e9b7350a4f7fffccfb36
Cr-Commit-Position: refs/heads/master@{#380913}