Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1787023003: Change star decoration to blue under MD (Mac). (Closed)

Created:
4 years, 9 months ago by shrike
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change star decoration to blue under MD (Mac). The bookmark star decoration is gray when the current site is bookmarked - it should be blue. This is under non-Incognito mode. BUG=594286 Committed: https://crrev.com/53ad822ccde462f719b7e595a0fd1dceebf00ae1 Cr-Commit-Position: refs/heads/master@{#380890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/location_bar/star_decoration.mm View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
shrike
PTAL
4 years, 9 months ago (2016-03-13 00:36:33 UTC) #3
Avi (use Gerrit)
lgtm Lookin' good.
4 years, 9 months ago (2016-03-13 00:51:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787023003/1
4 years, 9 months ago (2016-03-13 03:00:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-13 03:37:25 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-13 03:38:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53ad822ccde462f719b7e595a0fd1dceebf00ae1
Cr-Commit-Position: refs/heads/master@{#380890}

Powered by Google App Engine
This is Rietveld 408576698